Hi, Ramkumar Ramachandra wrote: > Since we want to develop the functionality to either pick or revert > individual commits atomically later in the series, make "commit" a > local variable. Doing this involves changing several functions to > take an additional argument, but no other functional changes. Okay, one more message review. Suppose I asked you what this patch does. You'd say it makes "commit" no longer a static variable, passing it around instead. Next I ask you why. The answer would presumably be something like "because ... static variables are bad", or "because passing it around explicitly makes it easier for a person reading the code to see how the state evolves", or "because some day we will want this to be thread-safe, meaning there could be more than one commit being cherry-picked at the same time". Right? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html