Ramkumar Ramachandra wrote: > [Subject: [PATCH 02/13] revert: Factor out add_message_to_msg function] "Factor out" means to introduce a new function. I think you mean "inline". :) > The add_message_to_msg function is poorly implemented, has an unclear > API, and only one callsite. Replace the callsite with a cleaner > implementation. The above does not answer the question I would have, namely what exactly is wrong with add_message_to_msg. Is it too slow? Not robust? Is the generated assembly too long? Is it hard for a reader to figure out the intent? Does it blend in poorly with its surroundings? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html