René Scharfe <rene.scharfe@xxxxxxxxxxxxxx> writes: > I'm not sure "filter" is a good name, though. We have core.pager, which > is technically a filter as well, but for a specific purpose. And we > have the tar.umask setting as a precedence for format specfic config > options. So how about tar.<extension>.compressor? > > [tar "tgz"] > compressor = gzip -cn > [tar "tar.gz"] > compressor = gzip -cn > [tar "tar.bz2"] > compressor = bzip2 -c > > We don't need a compressionlevels option here because we can simply > assume that the compressor commands do support them. (Side note: this > is not fully true for bzip2, as it doesn't support -0, but I don't think > this is worth special consideration in our code, as long as errors of > the filter are displayed properly.) > > And we can also add a config option to restrict the formats creatable by > upload-archive, to address concerns over DoS attacks with expensive > compressors: > > [archive] > remoteFormats = tar zip tgz tar.gz Both sounds sensible, I think. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html