Re: [PATCH 5/7] archive: refactor format-guessing from filename

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff King <peff@xxxxxxxx> writes:

> But more important is that the name hint is only a hint, and
> we default to the tar format. Which means that
> inconsistencies between the client's and server's set of
> formats will have confusing results. For example, imagine
> the client learns about "tar.gz" as an extension for gzip'd
> tar ("tgz") files, but the server does not. Locally,
> running:
>
>   git archive -o file.tar.gz HEAD
>
> will produce a gzip'd file. If we make the mapping decision
> locally, then running:
>
>   git archive --remote=origin -o file.tar.gz HEAD
>
> will send "--format=tgz" to the remote side. The server will
> complain, saying that it doesn't know about the tgz format.

As long as that complaint is clearly marked as coming from the remote
side, the user now knows that tgz is not supported, and can fall back to a
plain tar.

Am I being naÃve thinking that barfing (and assuming that the user
understands why the remote end barfed) actually is a good thing?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]