Sverre Rabbelier <srabbelier@xxxxxxxxx> writes:
> On Wed, Jun 15, 2011 at 07:59, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>> +perl -MCGI -MCGI::Util -MCGI::Carp -e 0 >/dev/null 2>&1 || {
>> + Â Â Â skip_all='skipping gitweb tests, CGI module unusable'
>> + Â Â Â test_done
>> +}
>> +
>
> Isn't the new style to use test_must_succeed CGI_AVAILABLE '...' '...'
> rather than skip_all+test_done?
I do not think that adds any value, at least in this case. Besides, look
at the context line above what you quoted ;-)
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html