Re: [PATCH] gitweb: allow space as delimiter in mime.types

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jakub Narebski <jnareb@xxxxxxxxx> writes:

> Ludwig Nussel <ludwig.nussel@xxxxxxx> writes:
>
>> Subject: [PATCH] gitweb: allow space as delimiter in mime.types
>
> A very minor nitpick: perhaps "work with" rather than "allow" would be
> better?

Allow is good; we earlier didn't allow space to be treated as delimiter,
with this patch we will do.

>> in openSUSE /etc/mime.types has only spaces. I don't know if there's
>> a canonical reference that says that only tabs are allowed. Mutt at
>> least also accepts spaces. So make gitweb more liberal too.
>
> Ack.
>
> It is obviously correct, as names of MUME types cannot contain spaces,
> it makes gitweb work with openSUSE /etc/mime.types, and it makes code
> simpler.
>
>> ---
>
> Signoff (i.e. Signed-off-by)?

Yes, sign-off is missing and necessary.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]