On Thu, Jun 09, 2011 at 06:59:15AM +0200, Andi Kleen wrote:
> > - Potential impact to people who do not use Gcc 4.6 with profile feedback
> > is not explained away well, except for "Doesn't seem to make any
> > difference."
>
> I merely went by "there are no new warnings" (I assume that's the main
> motivation)
On your compiler and settings, perhaps. With your patch I get:
usage.c: In function âdieâ:
usage.c:70:1: error: ânoreturnâ function does return [-Werror]
And rightfully so:
void NORETURN die(const char *err, ...)
{
va_list params;
va_start(params, err);
die_routine(err, params);
va_end(params);
}
You've stripped the NORETURN from die_routine, so of course it looks like we
end up returning.
This is with:
$ gcc --version | head -n 1
gcc (Debian 4.6.0-11) 4.6.1 20110604 (prerelease)
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html