Re: [PATCH 4/8] t5800: document some non-functional parts of remote helpers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff King <peff@xxxxxxxx> writes:

> On Wed, Jun 08, 2011 at 04:19:29PM -0700, Junio C Hamano wrote:
>
>> Jeff King <peff@xxxxxxxx> writes:
>> 
>> > The third test demonstrates a bug in git's side of the
>> > helper code when the upstream has added new refs without us.
>> 
>> without us knowing, you mean?
>
> I guess it depends what you mean by knowing. The bug is shown when the
> remote has a ref that we don't; we try to feed the name of that ref to
> fast-export, which of course doesn't work, because we don't have
> anything by that name.
>
> So in that sense, no, we don't know about the ref. But it is not about
> us knowing about the remote having the ref; the problem is that we _do_
> know that the remote has that ref, and assume we have a matching one.

Ok, I think I understood what the sentence wanted to say ("the upstream
added new refs. We do not have them yet", right?); it was just I found the
phrase "... without us" didn't sit well there to my ears.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]