Re: Sha1 lookup and GIT_USE_LOOKUP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Marc Pegon <pegon.marc@xxxxxxxxx> writes:

> Since this environment variable is not set by default, git will always
> use a simple binary search, won't it ?

Yes.

> Also, when searching for a sha1 given a sha1 prefix, among packed
> objects, find_short_packed_object also does a simple binary search.
> Wouldn't it be simpler to just use the sha1_entry_pos method ?

Unknown ;-).

The environment variable is there exactly for people like you who are
interested in finding out which one yields better performance by
benchmarking.  Once we can get a convincing result, we can either
deprecate the more involved sha1_entry_pos() if it turns out to be not
worth it, or we can always use it if it turns out to be significantly
better.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]