On Mon, Jun 06, 2011 at 09:05:11PM +0200, Sverre Rabbelier wrote: > On Mon, Jun 6, 2011 at 18:11, Jeff King <peff@xxxxxxxx> wrote: > > I'll try the nicer fix Sverre mentioned and post a real patch. I wanted > > to add a test for multiple refs to the test suite, but I got bogged down > > by other breakages. Some of which I think are the fault of testgit, but > > one of which I think may be a problem in the transport-helper code. > > I'm not 100% the current remote-helper code allows that, since there > might be some interaction where the transport-helper code needs to > read from the helper before closing the connection. I don't think > that's the case, but I'm not sure of it either. No, I think it is how the import command was expected to run. The order of the code in transport-helper.c is: 1. Redirect the incoming pipe to fast-import. 2. Print one or more "import $ref" lines. 3. Print "\n", then close the outgoing pipe. 4. Wait for fast-import to report completion. So there really is no room for further communication. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html