Hi, On 6 June 2011 10:20, Jeremie Nikaes <jeremie.nikaes@xxxxxxxxxxxxxxx> wrote: I've got some points of my own for consideration. > @@ -0,0 +1,306 @@ > +#! /usr/bin/perl > + > +use strict; use warnings; ? > +use Switch; Ugh -- no. This is terrible. Look at this: [~]% corelist Switch Switch was first released with perl v5.7.3 and removed from v5.13.1 Since you do not specify a minimum perl version you might be alright, but for those people on 5.14 -- they won't have this module, for good reason. You can, if you wanted use "given/when" as alternate constructs to this. > +use MediaWiki::API; > +use Storable qw(freeze thaw); This might have problems transcending storable formats made on a 32bit machine, and then trying to unpack them again on 64bit. Do you really need the need for these storable items to be encoded as binary? [...] -- Thomas Adam -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html