Jonathan Nieder wrote:
> tells getaddrinfo to restrict attention to TCP
> services after this patch. That should make a difference because the
> service parameter is NULL.
Sorry, the last sentence should say "That should _not_ make a
difference". You would be able to tell the difference between the
before and after with "strace git daemon" because of the ai_socktype
and ai_protocol settings:
[...]
> +int dns_resolve(const char *host, const char *port, int flags,
> + resolver_result *res)
> +{
> + struct addrinfo hints;
> + int gai;
> +
> + memset(&hints, 0, sizeof(hints));
> + if (flags & RESOLVE_CANONNAME)
> + hints.ai_flags = AI_CANONNAME;
> + hints.ai_socktype = SOCK_STREAM;
> + hints.ai_protocol = IPPROTO_TCP;
> +
> + gai = getaddrinfo(host, port, &hints, res);
but I don't think the effect is any different --- the ai_socktype and
protocol hints are for getservbyname functionality and the code that
cares about it was already passing those hints.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html