josh@xxxxxxxxxxxxxxxx writes: > Fair enough. We'd thought of NULL as a fairly logical representation > for a null ref sent as a dummy ref just to send capabilities,... I am not objecting to that part. NULL may be a logical thing to throw at when the interface is to take only strings that begin with refs/... and you have to occasionally send something different. But that is a line of thought that is only valid while there is only one "something different" (i.e. "capabilities^{}") and the current code happens to have only one such different thing to send, but the approach closes the door to allow us sending things other than that single exception in the future without redoing your patch. That was what I found objectionable. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html