On Fri, Jun 03, 2011 at 01:43:03AM -0400, Jeff King wrote: > On Fri, Jun 03, 2011 at 12:36:50AM -0500, Sverre Rabbelier wrote: > > > On Fri, Jun 3, 2011 at 00:18, Jeff King <peff@xxxxxxxx> wrote: > > > So I guess it doesn't like us asking for HEAD. But the fact that it > > > sends weird data to fast-import instead of saying "hey, HEAD doesn't > > > exist" has me confused. I'm not sure if this is something one should not > > > be doing with remote helpers, or if the testgit helper is simply buggy > > > or incomplete. > > > > Definitely the latter, quite possibly the former. I don't know if > > asking for "HEAD" makes much sense in a remote-helper context though. > > In Mercurial it does (e.g., tip), and in svn sort of, but I don't know > > about other vcs-es. Perhaps it should be guarded by a capability? > > Yeah, I think it depends on the helper. Definitely smart-http should be > able to do it. But protecting it with a capability does make sense, and > then remote helpers can opt into it. Actually, I forgot that I did consider this when writing the original patch. The clone code will only ask for HEAD if the remote side advertises it. So there is no capability required; either the helper advertises a HEAD ref or it doesn't. If it does, it should be prepared for us to ask for its sha1. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html