Re: [PATCHv4 2/4] Add infrastructure for ref namespaces

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jamey Sharp <jamey@xxxxxxxxxxx> writes:

> Note that namespaces which include a / will expand to a hierarchy of
> namespaces; for example, GIT_NAMESPACE=foo/bar will store refs under
> refs/namespaces/foo/refs/namespaces/bar/.  This makes GIT_NAMESPACE
> behave hierarchically, and avoids ambiguity with namespaces such as
> foo/refs/heads.

Sorry, but I fail to see what problem you are trying to solve here.  I am
not suggesting that it would be better to do things in a way different
from what your patch does, but what problem will you have if you stored
the branch head for baz in refs/namespaces/foo/bar/refs/heads/baz given
the namespace foo/bar, and how does it solve that problem to store it
instead at refs/namespaces/foo/refs/namespaces/bar/refs/heads/baz?


> +int for_each_namespaced_ref(each_ref_fn fn, void *cb_data)

Just a naming and interface preference, but I would have called this
for-each-ref-in-namespace, perhaps giving the namespace as a parameter.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]