On Tue, May 31, 2011 at 07:19, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Jeff King <peff@xxxxxxxx> writes:
>
>> On Mon, May 30, 2011 at 06:10:20PM +0200, Romain Geissler wrote:
>>
>>> > Have you considered pulling the parse-options parser from git into
>>> > libgit2? It's one of the more modularized and lib-ified bits of code in
>>> > git already.
>>>
>>> Yes and No. We have already copied some code from git : parse-option,
>>> the error handling functions, a part of the run-command block and a
>>> part of the compatibility layer. To my mind, there is no reason to
>>> pull it into libgit2 as it's only a client feature that works on
>>> strings, and libgit2 does not aim at being a client, only a git
>>> library.
>>
>> Yeah, good point. Definitely it should not be part of the libgit2
>> library itself.
>
> IIRC, libgit2 has a lot looser license than ours, and the core GPLv2 part
> of C git cannot be directly copied without authors' consent; relicensing
> of necessary parts of C git needs to be arranged.
Seems like a PITA:
$ git log --pretty=format:%an parse-options.[ch] | sort | uniq -c | sort -nr
19 Pierre Habouzit
15 Junio C Hamano
11 Renà Scharfe
9 Stephen Boyd
7 Jonathan Nieder
4 Johannes Schindelin
2 Michele Ballabio
1 Tuncer Ayaz
1 Thomas Rast
1 Olivier Marin
1 Nanako Shiraishi
1 Miklos Vajna
1 Mike Ralphson
1 Michael J Gruber
1 Mark Lodato
1 Linus Torvalds
1 Jeff King
1 Jake Goulding
1 Giuseppe Scrivano
1 Gary V. Vaughan
1 Christian Couder
1 Carlos Rica
1 Andreas Schwab
1 Alex Riesen
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html