On Sun, May 29, 2011 at 19:33, Shawn Pearce <spearce@xxxxxxxxxxx> wrote:
> On Sun, May 29, 2011 at 19:21, Shawn Pearce <spearce@xxxxxxxxxxx> wrote:
>> Although blame shows Stefan Lay removed the block in commit 05fa1713,
>> this isn't what happened. It was actually removed in commit 2302a6d3
>> by Christian Halstrick. It looks like blame gets confused around this
>> section of the JGit history.
Oh. Re-reading the man page for git blame helps. It says blame shows
the last revision that a line exists in, rather than the revision that
removed the line. IMHO, I expected reverse to show me the revision
that deleted (or replaced) that line, so I can inspect the commit
message and the contents of the patch. Showing me one of the potential
parents of that revision seems to be nearly useless.
Rereading commit 85af7929ee ("git-blame --reverse"), it seems you left
this an "exercise for the reader"... and in the past 3 years, no
reader has stepped forward to implement the exercise as a patch to
blame. *sigh*
--
Shawn.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html