On Sun, May 8, 2011 at 10:47, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> + Â Â Â Â Â Â Â char buf[10240];
> + Â Â Â Â Â Â Â size_t sz = size < sizeof(buf) ? size : sizeof(buf);
> + Â Â Â Â Â Â Â size_t actual;
> +
> + Â Â Â Â Â Â Â actual = read_in_full(fd, buf, sz);
> + Â Â Â Â Â Â Â if (actual < 0)
> + Â Â Â Â Â Â Â Â Â Â Â die_errno("index-stream: reading input");
>From clang:
sha1_file.c:2710:14: warning: comparison of unsigned expression <
0 is always false [-Wtautological-compare]
if (actual < 0)
~~~~~~ ^ ~
Looks like it's right. size_t is unsigned according to the standard,
so that die_errno() is never reached.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html