On Thu, May 26, 2011 at 05:19:52PM -0400, Jeff King wrote: > > > pp_title_line(CMIT_FMT_EMAIL, &msg, &sb, subject_start, extra_headers, > > > - encoding, need_8bit_cte); > > > + encoding, need_8bit_cte, 0); > > > > I do not appreciate a single-bit tweak as separate parameter to a > > function. Back when pp_title_line() had only "do we need 8-bit cte", it > > was Ok, but now that you are adding another bit, could we make it an > > "unsigned flag"? > > Actually, I wonder if we can refactor to just pass the pretty_context to > pp_title_line. Let me see what I can do. It ends up being a lot of lines changed, but I think the result is more readable. Replace my 3/3 with (1/5 and 2/5 are the same as before): [3/5]: pretty: add pp_commit_easy function for simple callers [4/5]: clean up calling conventions for pretty.c functions [5/5]: format-patch: preserve subject newlines with -k -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html