Re: [PATCH] remote: allow "-t" with fetch mirrors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 26, 2011 at 05:26:14PM +0200, Johannes Sixt wrote:

> Am 5/26/2011 17:11, schrieb Jeff King:
> > +	if (mirror && !(mirror & MIRROR_FETCH) && track.nr)
> > +		die("specifying branches to track makes no sense with non-fetch mirrors");
> 
> Don't proliferate no double negation. How about:
> 
> +		die("specifying branches to track makes sense only with fetch mirrors");

I can't fail to not disagree with your logic.

Junio, can you squash it in?

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]