The variable 'actual' was declared with a size_t type. In this line:
actual = read_in_full(fd, buf, sz);
read_in_full returns a ssize_t type. Since size_t is unsigned and
ssize_t is signed, the value is implicitly converted from a signed
type to an unsigned type. That makes this comparison useless,
if (actual < 0)
die_errno("index-stream: reading input");
as it will always be false. This means, on an error path, git will
continue when it should die gracefully.
This bug was introduced in 4dd1fbc.
Signed-off-by: Chris Wilson <cwilson@xxxxxxxxxxxxxx>
---
Hi Folks,
Sentry found this committed in last nights snapshot.
Chris Wilson
http://vigilantsw.com/
Vigilant Software
sha1_file.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sha1_file.c b/sha1_file.c
index 064a330..c251af8 100644
--- a/sha1_file.c
+++ b/sha1_file.c
@@ -2704,7 +2704,7 @@ static int index_stream(unsigned char *sha1, int fd, size_t size,
while (size) {
char buf[10240];
size_t sz = size < sizeof(buf) ? size : sizeof(buf);
- size_t actual;
+ ssize_t actual;
actual = read_in_full(fd, buf, sz);
if (actual < 0)
--
1.6.3.3
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html