Re: [PATCH] sh-18n: quell "unused variable" warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ãvar ArnfjÃrà Bjarmason venit, vidit, dixit 26.05.2011 01:33:
> On Wed, May 25, 2011 at 11:55, Michael J Gruber
> <git@xxxxxxxxxxxxxxxxxxxx> wrote:
> 
> I suppose it was inevitable that we'd end up maintaining this since
> upstream only maintains the GPLv3 version now.
> 
>>   /* Default values for command line options.  */
>> -  unsigned short int show_variables = 0;
>> +  /* unsigned short int show_variables = 0; */
> 
>> -         show_variables = 1;
>> +         /* show_variables = 1; */
> 
> Can we just remove these lines instead of commenting them out?

Sure, I just didn't know what is more convenient for the maintainer. I
noticed a few comments in there already but have not compared with
upstream. Resend necessary?

Michael
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]