Hi, On Wed, 25 May 2011, Josh Triplett wrote: > On Thu, May 26, 2011 at 01:53:42AM +0200, Johannes Schindelin wrote: > > On Wed, 25 May 2011, Jamey Sharp wrote: > > > On Wed, May 25, 2011 at 08:51:07AM +0200, Johannes Schindelin wrote: > > > > 2) You're extending the protocol by appending the prefix after the > > > > SHA-1, and I stopped halfway through the patch trying to find > > > > information which I now think should be in the commit message: a) > > > > why? b) why does it not break when one of the two sides is a > > > > previous version? > > > > > > I don't think we're changing the protocol in any way...? > > > > Did your patch series not contain a change that sends a capability with > > the prefix appended? > > Not that we know of. Are we missing something? This is a change of protocol by my understanding: -- snip -- if (sent_capabilities) - packet_write(1, "%s %s\n", sha1_to_hex(sha1), path); + packet_write(1, "%s %s%s\n", sha1_to_hex(sha1), refnameprefix, path); -- snap -- Of course, you're free to ignore my comments just like everybody else on the Git mailing list. Ciao, Johannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html