On Wed, May 25, 2011 at 09:52:56AM +0200, Matthieu Moy wrote:
> Chris Wilson <cwilson@xxxxxxxxxxxxxx> writes:
>
> > Oops, I see others putting the patches inline. Here you go.
>
> Please, read Documentation/SubmittingPatches. Especially read about
> signed-off-by and the way patches should be formatted (git send-email
> would help).
Thanks, trying this again. Like I said before, the author should
investigate if this variable should have been used before removing it.
Signed-off-by: Chris Wilson <cwilson@xxxxxxxxxxxxxx>
---
sh-i18n--envsubst.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/sh-i18n--envsubst.c b/sh-i18n--envsubst.c
index 7125093..5829463 100644
--- a/sh-i18n--envsubst.c
+++ b/sh-i18n--envsubst.c
@@ -67,9 +67,6 @@ static void subst_from_stdin (void);
int
main (int argc, char *argv[])
{
- /* Default values for command line options. */
- unsigned short int show_variables = 0;
-
switch (argc)
{
case 1:
@@ -88,7 +85,6 @@ main (int argc, char *argv[])
/* git sh-i18n--envsubst --variables '$foo and $bar' */
if (strcmp(argv[1], "--variables"))
error ("first argument must be --variables when two are given");
- show_variables = 1;
print_variables (argv[2]);
break;
default:
--
1.7.5.2.354.g19aea
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html