Jeff King venit, vidit, dixit 24.05.2011 21:13: > On Tue, May 24, 2011 at 09:19:43AM +0200, Michael J Gruber wrote: > >>> It is conceivable that we _could_ newly define a "combined external diff >>> driver" that would take 3 or more files, and compute and show the combined >>> result by itself, but that will certainly not go through the codepath you >>> touched with the textconv patch. Calling out to such a new type of >>> external diff driver would have to happen at the level where we have 1+N >>> blob object names for a N-parent commit, namely, at the beginning of >>> show_patch_diff(), bypassing the entire contents of that function and >>> instead letting the new n-way external diff driver do everything. >>> >>> I however highly doubt that such an interface would make sense. For >>> example, what would be the desirable format to compare three versions of >>> "What's cooking" postings, and how would the updated compare-cooking.perl >>> script would look like? >> >> Yeah, currently --cc with external makes no sense, but there are several >> external tools which could present a 3-way diff in a useful way (or even >> n-way with n>3), e.g. vimdiff, kdiff3, meld. > > I agree with Junio that we would need a new config option and external > interface for "n-way combined diff". However, isn't what things like > vimdiff and meld do the reverse of our combined diff? That is, don't > they assume the 3 trees are: ours, theirs, and ancestor (i.e., merge > base)? Whereas in a combined diff, it is actually: merge parent 1 > (ours), merge parent 2 (theirs), and merge _result_. > > Also, do those tools generally handle n-way comparisons as opposed to > 3-way? "Those" tools do "that" which I mean :) It depends on the tool, of course. vimdiff does not have any assumptions that I know of, it marks those hunks which are not common to all buffers, and marks them differently depending on what subset of buffers shares them. That aspect is the same for kdiff3 and meld (n<=3 for meld) in diff mode. There are more differences in merge mode: In vimdiff, you can "put" a hunk (i.e. apply the change) to another buffer (or "obtain" one), i.e. you can easily move hunks between the buffers (to do a merge). In kdiff3's auto merge mode there is the assumption you mention (because it actively does some merging). So, in vimdiff, you could in principle change and write any buffer but our tools don't support it so far because it is not needed for a merge which has one "target" only. In the ui of my dreams, I would have 3 buffers HEAD INDEX WORKTREE (H I W) and moving hunks between them would do all of add -p, reset -p and checkout -p (the HEAD buf would be read-only). With "differently abled" tools it could still be useful to have, say a tool invoked for the merge HEAD+WORKTREE -> INDEX (with the current state of the INDEX as the automatic resolution to start off from) so that you can do add+reset -p with your mergetool, and maybe similarly for HEAD+INDEX -> WORKTREE. I.e. addtool and checkouttool in addition to the difftool and mergetool which we have. Just not for the current release cycle any more. Michael -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html