On Tue, May 24, 2011 at 12:46 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Jeff King <peff@xxxxxxxx> writes: > >>> However, custom diff drivers (still) don't work. :-) >> >> Yeah, I didn't add any support for that. I'm not sure what it should do; >> custom diff drivers don't know how to handle combined diff, do they? >> >> If you write me a test case that explains what _should_ happen, I'll see >> what I can do. :) > > I do not think it is sensible to expect anybody to come up with a sane > semantics for combined diff to work with GIT_EXTERNAL_DIFF (and external > diff driver that can be specified via the attributes mechanism) in any > meaningful way. Indeed, it was a thinko that I even considered it. It turns out I had been using an external diff command where I should have been using textconv all along. j. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html