Jeff King <peff@xxxxxxxx> writes: > + } else if (textconv) { > + /* yuck, the textconv code is linked heavily with > + * filespecs */ > + struct diff_filespec *df = alloc_filespec(""); > + fill_filespec(df, sha1, mode); > + *size = fill_textconv(textconv, df, &blob); I thought your 4/5 talked something about not requiring filespec for textconv handling...? Is it still yuck? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html