Renà Scharfe <rene.scharfe@xxxxxxxxxxxxxx> writes: > Am 21.05.2011 23:05, schrieb Renà Scharfe: >>> + if (ident->state < sizeof(head) && >> >> // minus one because otherwise we'd compare the >> // terminating NUL as well even though we're not >> // actually looking for a NUL >> if (ident->state < sizeof(head) - 1 && > > Possibly, but that doesn't matter, as the right number of characters is > remembered and the second test below is not passed if we sailed past the > NUL. Sorry for the noise. Thanks for a careful reading. In the second re-roll, I'll split the cascade and ident into two patches (ident comes first, with a fake cascade that returns NULL to indicate there is no cascading supported when two "real" filters are given). Also I do not need two buffers in the cascade. The input to cascade can be fed directly to the input of cascade->one to fill the cascade's buffer, and we can feed cascade->two with what is in the cascade's buffer to directly drain to the output of the cascade. But that won't happen today. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html