Re: [PATCH v2 06/11] streaming: a new API to read from the object store

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Renà Scharfe <rene.scharfe@xxxxxxxxxxxxxx> writes:

>> +#define read_method_decl(name) \
>> +	ssize_t read_istream_ ##name \
>> +	(struct git_istream *st, char *buf, size_t sz)
>
> It would be nice if those macros could be got rid of once the interface
> stabilizes.

Probably, but not while it is still in flux in 'pu'. I already had to
tweak something to support my unpublished series I was working on today.

>> +struct git_istream {
>> +	enum input_source source;
>
> source seems to be write-only.

Yes, I had this initially but later ended up with a design that makes
everything go through vtbl, so this is only useful for debugging and can
be removed.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]