Re: [PATCH] compat: add a getpass() compatibility function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 19.05.2011 um 23:16 schrieb Erik Faye-Lund:
>> 
>> Well, those platforms would currently fail, since that's the limit on
>> the string returned from getpass. Since that hasn't happened yet, I
>> suspect that this is a very theoretical problem.
>> 
>> If we created our own define we could fix such problems by setting
>> NO_GETPASS and having a reasonable lengthy GIT_MAX_PASS. But let's
>> leave that theoretical fix for when/if it turns out to be real, huh?
>> 
> 
> Whoa: http://www.opengroup.org/csq/view.mhtml?norationale=1&noreferences=1&RID=sun%2FSE2%2F10
> 
> It seems that Solaris has a MAX_PASS of 8... That should mean that
> prompted passwords can't be above 8 characters there (without using
> GIT_ASKPASS). Can this really be the case?

Good find. At least under "SunOS opensolaris 5.11 snv_111b i86pc i386 i86pc" with packages from http://sunfreeware.com/indexintel10.html, I can confirm exactly this behavior. If you try to connect to an account with password > 8 chars, git-imap-send prints "IMAP command 'LOGIN <user> <pass>' returned response (NO) - incorrect password or account name", using <= 8 chars it works fine (couldn't check git clone on https because I only have an internal IP without NAT/proxy).

So maybe it would make sense to define NO_GETPASS and use compat/getpass.c on Solaris in the Makefile?


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]