Re: [PATCH v7] Add log.abbrevCommit config variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jay Soffian <jaysoffian@xxxxxxxxx> writes:

> +test_expect_success 'log.abbrevCommit configuration' '
> +	test_when_finished "git config --unset log.abbrevCommit" &&

Now, when this test begins, what is the value of log.abbrevCommit?

I'd add an explicit

	test_might_fail git config --unset log.abbrevCommit &&

here.

> +	git log --abbrev-commit >expect.log.abbrev &&
> +...
> +	test_cmp expect.reflog.full actual

Break in && chain here.

> +	git whatchanged >actual &&
> +	test_cmp expect.whatchanged.abbrev actual

Ditto.

> +	git whatchanged --no-abbrev-commit >actual &&
> +	test_cmp expect.whatchanged.full actual
>  '
>  
>  test_expect_success 'show added path under "--follow -M"' '

I've squashed these in before queuing, so unless you found other issues,
no need to resend.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]