On Tue, May 17, 2011 at 05:38:52PM +0200, Michael J Gruber wrote: > The return codes of git_config_set() and friends are magic numbers right > in the source. #define them in cache.h where the functions are declared, > and use the constants in the source. > > Also, mention the resulting exit codes of "git config" in its man page > (and complete the list). This version (and the accompanying 2/2) both look sane to me. Thanks for taking time to clean up. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html