On Tue, May 17, 2011 at 2:50 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Care to explain why your check has to be different?
It doesn't. I thought through it poorly.
>ÂIf there is no reason
> to use a different logic, then a natural thing to do is to rewrite the
> existing decoration logic and add yours like this:
>
> Â Â Â Âif (rev->pretty_given && rev->commit_format == CMIT_FMT_RAW) {
> Â Â Â Â Â Â Â Â/* "log --pretty=raw" is special */
> Â Â Â Â Â Â Â Âif (!decoration_given)
> Â Â Â Â Â Â Â Â Â Â Â Âdecoration_style = 0;
> Â Â Â Â Â Â Â Âif (!abbrev_commit_given)
> Â Â Â Â Â Â Â Â Â Â Â Ârev->abbrev_commit = 0;
> Â Â Â Â}
It would be lovely if you could squash that in.
Thanks,
j.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html