Re: [PATCHv2] gitweb: Use GITWEB_CONFIG_SYSTEM even if GITWEB_CONFIG does exist

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jakub Narebski <jnareb@xxxxxxxxx> writes:

> This commit changes gitweb behavior so that configuration in
> per-instance configuration file can _override_ settings from
> system-wide configuration file.
>
> Note that strictly speaking it is backwards incompatible change.

I am not sure if we gain enough from this change.  As the system-wide one
can be arbitrarily overriden by per-instance one, the goal of this change
cannot be to make sure that the system administrator can enforce the
system wide policy over all the gitweb instances.

I think the goal is to let per-instance configuration have an easy way to
inherit from a common sane default, but if that is the case, wouldn't it
be a lot safer and more backward compatible way to just instruct people to
include that common default configuration at the beginning of per-instance
configuration file instead?  After all, you would need to give some advice
like this ...

> Check your resulting gitweb configuration, please.

... either way.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]