Thiago Farina <tfransosi@xxxxxxxxx> writes: > In the commit message you say to return "enum object_name". Maybe > change from int to enum object_name here and below? As other functions that return -1 on error return int as a convention, I do not think it is a good change. As you may have noticed, "enum object_name" is not correct. It should be "enum object_type" I think. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html