On Mon, May 16, 2011 at 23:26, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > Ãvar ArnfjÃrà Bjarmason wrote: > >> That would require us to start extracting strings from all "say" >> functions. The reason we have only "gettext" and "eval_gettext" is so >> xgettext can extract them. > > Isn't that what the xgettext -k parameter is for? I'm not saying we can't use xgettext to extract these things. I'm saying I don't think it's a good idea. $ git --no-pager grep say git-submodule.sh git-submodule.sh: say "$(eval_gettext "Entering '\$prefix\$path'")" git-submodule.sh: say "$(eval_gettext "Submodule '\$name' (\$url) registered for path '\$path'")" git-submodule.sh: say "$(eval_gettext "Submodule path '\$path' not initialized git-submodule.sh: say_msg="$(eval_gettext "Submodule path '\$path': rebased into '\$sha1'")" git-submodule.sh: say_msg="$(eval_gettext "Submodule path '\$path': merged in '\$sha1'")" git-submodule.sh: say_msg="$(eval_gettext "Submodule path '\$path': checked out '\$sha1'")" git-submodule.sh: say $say_msg git-submodule.sh: say "U$sha1 $displaypath" git-submodule.sh: say "-$sha1 $displaypath" git-submodule.sh: say " $sha1 $displaypath$revname" git-submodule.sh: say "+$sha1 $displaypath$revname" git-submodule.sh: say "$(eval_gettext "Synchronizing submodule url for '\$name'")" I want to mark *some* of these *manually* as translatable, I don't want to go and extract strings from all invocations to functions like printf & die, instead I want to add a printf(_()) wrapper to everything. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html