Re: [BUG?] read_directory(), core.ignorecase and pathspec

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Nguyen Thai Ngoc Duy <pclouds@xxxxxxxxx> writes:

> I was looking at how read_directory() uses pathspec, and it seems that
> simplify_away(), the function that cuts out directories early if
> they're definitely outside given pathspec, does exact match (ie.
> memcmp) regardless core.ignorecase. This means "git add -- '*.c'" may
> not work as expected when core.ignorecase is on.

I don't think for '*.c' it would make any difference, but it is very
plausible that 'frotz/*.c' will cull 'Frotz/anything' as "never going to
match".

> The whole simplifying thing in read_directory() will eventually be
> replaced with real pathspec matching as we put more magic in pathspec.

That should be done not "as" but "before". Get the foundation right before
going fancier.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]