On Tue, May 10, 2011 at 11:51 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: <snip> > >> + ... >> + Â Â p4_check_commit_author usernamefile3 alice && >> + Â Â cd "$TRASH_DIRECTORY" && >> + Â Â rm -rf "$git" && mkdir "$git" >> +' > > When the commands in the && chain fails after 'cd "$git"' near the top but > not before 'cd "$TRASH_DIRECTORY"' near the end, you would end up starting > the next test from somewhere different from "$TRASH_DIRECTORY". > > Do it like this instead: > > Â Â Â Â"$GITP4" clone --dest="$git" //depot && > Â Â Â Â( > Â Â Â Â Â Â Â Âcd "$git" && > Â Â Â Â Â Â Â Â... > Â Â Â Â) && > Â Â Â Ârm -fr "$git" > Thanks - that might explain a few oddities I had when testing. There's a few others of those in the earlier tests; I'll resend this patch, and send a second patch to fix those if that's ok. Regards! Luke -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html