On Sun, May 8, 2011 at 19:15, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Ãvar ArnfjÃrà Bjarmason Â<avarab@xxxxxxxxx> writes: > >> Add a git-sh-i18n--envsubst program which is a stripped-down version >> of the GNU envsubst(1) program that comes with GNU gettext for use in >> the eval_gettext() fallback > > Ok up to this point. > >> ... instead of using a clever (but broken) >> printf + eval + printf trick. >> >> In a previous incarnation of the gettext series I implemented the >> eval_gettext() fallback like this: >> ... >> This was clever, but ... >> ... >> To work around this, and to improve our variable expansion behavior >> (eval has security issues) I've imported a stripped-down version of >> gettext's envsubst(1) program. > > I do not think the lengthy history of failed experiments above is worth > explaining. If you really want to say something to justify a new helper, I > think it is sufficient to just explain that it is unsolvable in shell. I > tried that in the first 9-line paragraph in: > > Âhttp://thread.gmane.org/gmane.comp.version-control.git/170703/focus=170770 > > In other words, "we tried X that didn't work and we tried Y that didn't > either, we cannot think of any better solution, so we are doing something > else" is not a good justificiation for doing that "something else". > > "Anything based on shell is an unpractical solution for this and that > reasons, so we use this instead" explains that the earlier failures were > not because we did not try hard enough. ÂUnlike "tried X and Y but didn't > work", dismissing "anything based on shell" as a whole class with clear > explanation why it would not work would prevent people from pursuing that > dead-end approach. ÂIt also avoids giving quibbling people an excuse to > argue against importing envsubst implementation saying "you didn't try > hard enough". I included the failed experiments because I know for sure that those don't work, but I'm not sure that this is impossible in shell, and it might be possible in some non-POSIX shell (which we could optionally take advantage of on certain platforms in the future). So having the failed examples that we know don't work is valuable for anyone digging into this in the future. Or are we sure that this can't work in POSIX (or non-POSIX shells)? >> With it eval_gettext() is implemented >> like this: >> ... >> Reported-by: Johannes Sixt <j.sixt@xxxxxxxxxxxxx> >> Signed-off-by: Ãvar ArnfjÃrà Bjarmason <avarab@xxxxxxxxx> > > Ok. > >> diff --git a/Documentation/git-sh-i18n--envsubst.txt b/Documentation/git-sh-i18n--envsubst.txt >> new file mode 100644 >> index 0000000..e146a2c >> --- /dev/null >> +++ b/Documentation/git-sh-i18n--envsubst.txt >> @@ -0,0 +1,36 @@ >> ... >> +Author >> +------ >> +Written by Ãvar ArnfjÃrà Bjarmason <avarab@xxxxxxxxx> >> + >> +Documentation >> +-------------- >> +Documentation by Ãvar ArnfjÃrà Bjarmason and the git-list >> +<git@xxxxxxxxxxxxxxx>. > > I do not think we do these individual credits these days in the doc. I wrote this when that was the convention, but evidently we've changed that since then. I'll remove it in the next iteration. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html