Re: [PATCH 16/48] i18n: git-pull eval_gettext + warning message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> [110508 14:23]:
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>
> ---
>  git-pull.sh |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/git-pull.sh b/git-pull.sh
> index 06dcd81..79ba9ab 100755
> --- a/git-pull.sh
> +++ b/git-pull.sh
> @@ -217,9 +217,9 @@ then
>  	# $orig_head commit, but we are merging into $curr_head.
>  	# First update the working tree to match $curr_head.
>  
> -	echo >&2 "Warning: fetch updated the current branch head."
> -	echo >&2 "Warning: fast-forwarding your working tree from"
> -	echo >&2 "Warning: commit $orig_head."
> +	echo >&2 "$(eval_gettext "Warning: fetch updated the current branch head.
> +Warning: fast-forwarding your working tree from
> +Warning: commit \$orig_head.")"

echo "$(...)"

sounds quite wasteful and harder to read than necessary.
The same also happens in later patches.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]