Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > On Sat, 25 Nov 2006, Anand Kumria wrote: > >> Any reason you didn't do: >> >> if (!commit->util) >> commit->util = xcalloc(1, sizeof(int)); > > xmalloc() does not initialize the memory. Therefore, it is usually > preferred if you initialize the memory yourself. In this case, the memory > is initialized to 0, even if it is not allocated. > > It may be a minor performance issue, but it is a good habit to use xcalloc > only if it is needed. I think you could pretend the commit->util field to be of some kind of int and avoid the allocation altogether ;-). - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html