Re: [PATCH 1/2] tests: eliminate unnecessary setup test assertions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff King <peff@xxxxxxxx> writes:

> Two minor complaints on git-blame; maybe somebody can point out
> something clever I've missed.

>   1. blame's "-L" understands patterns already.

Teaching blame to take multiple -L options has been one of many
longstanding todo item for me.  Someday.

>   2. Parsing the human-readable output blame output sucks. But parsing
>      --porcelain is annoyingly complex for quick-and-dirty things like
>      this. It doesn't repeat the commit information per-line.

Non-repetition was quite deliberate, as the reader was expected to have
memory proportional to the number of lines in the range, but I agree it is
not friendly for quick and dirty hack.

You should be able to add a command line option that disables the early
return at the beginning of emit_one_suspect_detail() with a 5-6 lines of
patch.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]