Currently verify_parents only makes sure that the earlier parents of HEAD match the commits given, and does not care if there are more parents. This makes it harder than one would like to check that, for example, parent reduction works correctly when making an octopus. Fix it by checking that HEAD^(n+1) is not a valid commit name. Noticed while working on a new test that was supposed to create a fast-forward one commit ahead but actually created a merge. Reported-by: Junio C Hamano <gitster@xxxxxxxxx> Signed-off-by: Jonathan Nieder <jrnieder@xxxxxxxxx> --- t/t7600-merge.sh | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/t/t7600-merge.sh b/t/t7600-merge.sh index c665acd..9af748a 100755 --- a/t/t7600-merge.sh +++ b/t/t7600-merge.sh @@ -89,6 +89,7 @@ verify_parents () { i=$(expr $i + 1) || return 1 done && + test_must_fail git rev-parse --verify HEAD^$(($# + 1)) && test_cmp parents.expected parents.actual } -- 1.7.5.1 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html