Re: [PATCH] staging: brcm80211: SDIO/MMC cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/06/2011 06:07 PM, Junio C Hamano wrote:
Michael J Gruber<git@xxxxxxxxxxxxxxxxxxxx>  writes:

Junio C Hamano venit, vidit, dixit 06.05.2011 16:37:
"Arend van Spriel"<arend@xxxxxxxxxxxx>  writes:

The git documentation on the git am command is not very elaborate. I
investigated the issue and checked following:
1. line 135 in dhd_sdio.c in the patch does match line 135 in my
checked out branch.
Does it exactly match, or does it merely visually match if you ignore tabs
and spaces munged by somebody between the state of the file submitter
committed and grunder.eml file you stored?
Junio, he reported the hashes to match! Puzzling. Or a MUA doing things
to the .eml.
The latter is exactly what I meant.  The mailchain leading to the
receiver's mailbox would not adjust the hash recorded in the patch when it
munges whitespaces.

Tried patch -p1 < grundler.eml. That gives info at which line it fails. I believe we have to blame Thunderbird here as you suspected. It placed a line break because to line was too long. Crap! Why do tools have to be "smart"?

Gr. AvS


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]