Re: [PATCH] Fix test t3701-add-interactive.sh

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Kacper Kornet <draenog@xxxxxxxxxxxxx> writes:

> One of the tests used to fail due to EOF not in the first column and not
> continued &&.
>
> Signed-off-by: Kacper Kornet <draenog@xxxxxxxxxxxxx>
> ---
>  t/t3701-add-interactive.sh |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t3701-add-interactive.sh b/t/t3701-add-interactive.sh
> index d6327e7..018f5d9 100755
> --- a/t/t3701-add-interactive.sh
> +++ b/t/t3701-add-interactive.sh
> @@ -83,9 +83,9 @@ EOF
>  
>  test_expect_success PERL 'setup fake editor' '
>  	cat >fake_editor.sh <<EOF
> -	EOF
> +EOF
>  	chmod a+x fake_editor.sh &&
> -	test_set_editor "$(pwd)/fake_editor.sh" &&
> +	test_set_editor "$(pwd)/fake_editor.sh"
>  '

Very curious. I never saw the breakage.  We are getting:

./test-lib.sh: line 450: warning: here-document at line 447 delimited by
end-of-file (wanted `EOF')

Well spotted.  Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]