Re: [PATCH 1/1] Honor $(prefix) set in config.mak* when defining ETC_GIT* and sysconfdir

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Sixt <j.sixt@xxxxxxxxxxxxx> writes:

> No, that's not sufficient. Notice that $(sysconfdir) is used for ETC_GIT*
> variables *only* if $(prefix) == /usr (both before and after Kacper's
> patch). Therefore, you won't gain a lot of configurability via sysconfdir;
> you have to change ETC_GIT* variables directly.

Huh?  You lost me.

The point of this approach is to make a progress without regressing, and
the (minimum) progress needed to be made that comes from the beginning of
this discussion is that setting $(prefix) from the command line of make
works but it does not when it is set in config.mak (or config.mak.autogen
which in turn is added by running "./configure --prefix=...").

As the "relocatable installation" topic wants to make everything relative
to prefix, I do not know if it is even worth trying to support a build
that has prefix set to anything other than /usr to set ETC_GIT* variables
to an arbitrary absolute path via --sysconfdir. I suspect that would
defeat the whole "relocatable" concept. More importantly, since I do not
care too much about "relocatable", I do not want to even have to worry
about it.

So the only thing my suggested approach tries to fix on top of Kacper's
patch is not to regress use of "sysconfdir = /some/where" when prefix is
set to /usr.

If you really care about being able to use sysconfdir together with the
relocate logic, I think you first have to rethink "if $(prefix) == /usr"
and change it into a new "RELOCATABLE_GIT = YesPlease/NoThanks".  After
all, even when you set prefix to /usr/local, you may want the installed
binaries know where to look without the "let's find everything relative
to /usr/local/bin/git" logic.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]