MichaÅ Kiedrowicz <michal.kiedrowicz@xxxxxxxxx> writes:
> diff --git a/Makefile b/Makefile
> index 3a1fe20..98841dc 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -24,6 +24,12 @@ all::
> # Define NO_OPENSSL environment variable if you do not have OpenSSL.
> # This also implies BLK_SHA1.
> #
> +# Define NO_LIBPCRE if you do not have libpcre installed. git-grep cannot use
> +# Perl-compatible regexes.
At least at first, I'd rather want to keep this an optional feature, i.e.
+# Define WITH_LIBPCRE if you have and want to use libpcre.
> @@ -33,6 +39,8 @@ struct grep_pat {
> size_t patternlen;
> enum grep_header_field field;
> regex_t regexp;
> + pcre *pcre_regexp;
> + pcre_extra *extra;
I don't think pcre will forever stay the _only_ thing that wants to hook
an extra information to this structure. That is why I included "pcre_" in
the field name in my earlier "how about doing it this way" suggestion.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html