Re: [PATCH] grep: add known breakage of coloring when using extended patterns

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Renà Scharfe <rene.scharfe@xxxxxxxxxxxxxx> writes:

>> +	test_commit initial input "foo bar baz
...
>> +	git grep --color -e foo --or \( -e bar --and --not -e baz \) |
...
> The current code highlights the given search terms ("atoms").

Hmm, I was probably not paying attention to "coloring the parts that
matched" topic at all, but wouldn't it be easier and more efficient to
paint only "foo" without painting "bar baz"?  We know the first term "foo"
matches, and the rest \(...\) that is --or'ed does not have to even be
evaluated, no?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]