Sylvain Rabot <sylvain@xxxxxxxxxxxxxx> writes:
> Signed-off-by: Sylvain Rabot <sylvain@xxxxxxxxxxxxxx>
Please keep in mind that these individual commits will eventually need an
entry added to Documentation/Relnotes/1.7.5.1.txt where I describe what
bug was fixed in a single paragraph, and it almost always talks about how
a bug would have been triggered so that the readers can tell if the fix
would benefit them.
It would have been perfect if you wrote under what condition the user
would see this error message in the body of the commit.
> ---
> git-send-email.perl | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index 76565de..98ab33a 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -1091,7 +1091,7 @@ X-Mailer: git-send-email $gitversion
> "VALUES: server=$smtp_server ",
> "encryption=$smtp_encryption ",
> "hello=$smtp_domain",
> - defined $smtp_server_port ? "port=$smtp_server_port" : "";
> + defined $smtp_server_port ? " port=$smtp_server_port" : "";
If I were writing this from scratch, I probably would have written it
by having leading SP for all options, perhaps like this:
"VALUES:",
" option=value",
" option=value",
(showoption) ? " option=value" : "",
(showoption) ? " option=value" : "",
...
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html