On Fri, Apr 29, 2011 at 11:12 AM, <david@xxxxxxx> wrote:
> On Fri, 29 Apr 2011, Jon Seymour wrote:
>
>> However, let's start simple, what would a minimal plugin directory
>> look like and, assuming there was one per git-install, where would it
>> be located relative to the prefix?
>>
>> Here's a suggestion for the layout:
>>
>> bin/
>> Â- all scripts and sh libraries
>> man/
>> Â- all man pages
>> html/
>> Â- all html pages
>>
>> What about location?
>>
>> Â${prefix}/git-plugins
>> Â${prefix}/lib/git-plugins
>>
>> Or, decided by distribution?
>
> distros are going to change this anyway, so start by accepting that, then
> make the default just that, a default, not something hard-coded.
>
Yep. Hopefully whatever the distro decided path would be available via
a git --plugins-path switch?
Might not be necessary if we let plugins install into --exec-path,
--html-path and (proposed) --man-path.
>> Is there support for the idea of adding a --man-path switch to the main
>> line?
>>
>> What about a --plugins-path, that would answer the question about
>> where plugins should go?
>
> I think it would be better to put it in the config file, nobody is going to
> add command line options to every command they run.
The intent here is to help package managers and plugin authors to
decide where they place plugin artifacts like scripts and others
resources. Similar to the existing --html-path and --exec-path
options.
>
>> Per Jonathan's and Junio's suggestions, the idea of having a plugins
>> search path seems like a reasonable one, so that users without control
>> over the git install can at least customize it themselves.
>
> only if you make sure that the plugins only run as the user, with no chance
> of them being invoked as a privilaged user.
>
Sure.
Thank you!
jon.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html